feat(community-pagination): design changes

BREAKING CHANGE: Default visual designs have changed
telus · Oct 10, 2019 · 4d0d662 · 4d0d662
1 parent c648bc3
commit 4d0d662
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/packages/Pagination/Pagination.jsx b/packages/Pagination/Pagination.jsx
@@ -254,11 +254,9 @@ Pagination.propTypes = {
   /**
    * The default copy to be used.
    */
-  copy: PropTypes.oneOf(['en', 'fr']),
+  copy: PropTypes.oneOf(['en', 'fr']).isRequired,
 }
 
-Pagination.defaultProps = { copy: 'en' }
-
 Pagination.Panel = Panel
 
 export default Pagination
diff --git a/packages/Pagination/__tests__/__snapshots__/Pagination.spec.jsx.snap b/packages/Pagination/__tests__/__snapshots__/Pagination.spec.jsx.snap
@@ -33,14 +33,13 @@ exports[`Pagination renders 1`] = `
   color: #4b286d;
   font-size: 1rem;
   line-height: 42px;
-  visibility: hidden;
+  display: none;
 }
 
 .c12 {
   color: #4b286d;
   font-size: 1rem;
   line-height: 42px;
-  visibility: visible;
 }
 
 .c3 {
@@ -257,9 +256,7 @@ exports[`Pagination renders 1`] = `
   }
 }
 
-<Pagination
-  copy="en"
->
+<Pagination>
   <styles__PaginationContainer>
     <StyledComponent
       forwardedComponent={

diff --git a/packages/Pagination/styles.jsx b/packages/Pagination/styles.jsx
@@ -27,11 +27,11 @@ const BasePaginationContainer = styled.p({
 })
 
 export const PrevPaginationContainer = styled(BasePaginationContainer)(props => ({
-  visibility: props.showPrevious ? 'visible' : 'hidden',
+  display: !props.showPrevious && 'none',
 }))
 
 export const NextPaginationContainer = styled(BasePaginationContainer)(props => ({
-  visibility: props.showNext ? 'visible' : 'hidden',
+  display: !props.showNext && 'none',
 }))
 
 export const PaginationButtonStyle = styled.button({