fix(community-toggle-switch): makes spinnerLabel prop optional

ToggleSwitch required spinnerLabel, yet isLoading prop is optional. spinnerLabel is only needed in cases where isLoading prop is passed. Fixes issue 311
telus · Jan 31, 2020 · ee04d07 · ee04d07
1 parent dca3d4d
commit ee04d07
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/ToggleSwitch/ToggleSwitch.jsx b/packages/ToggleSwitch/ToggleSwitch.jsx
@@ -113,7 +113,7 @@ ToggleSwitch.propTypes = {
   tooltipCopy: PropTypes.string,
 
   /** Communicates a message to assistive technology while spinner is visible. */
-  spinnerLabel: PropTypes.string.isRequired,
+  spinnerLabel: PropTypes.string,
 
   /** A callback function to be invoked when the ToggleSwitch button is clicked on.
    @param {SyntheticEvent} event The React `SyntheticEvent` */
@@ -127,6 +127,7 @@ ToggleSwitch.defaultProps = {
   checked: false,
   tooltipText: undefined,
   tooltipCopy: undefined,
+  spinnerLabel: undefined,
   isLoading: false,
 }
 

diff --git a/packages/ToggleSwitch/__tests__/ToggleSwitch.spec.jsx b/packages/ToggleSwitch/__tests__/ToggleSwitch.spec.jsx
@@ -11,7 +11,6 @@ describe('ToggleSwitch', () => {
     name: 'name',
     value: 'value',
     toolTipCopy: 'en',
-    spinnerLabel: 'Request is processing.',
     onClick: mockOnClick,
   }
 
@@ -150,7 +149,10 @@ describe('ToggleSwitch', () => {
   })
 
   it('show spinner when isLoading=true', () => {
-    const toggleSwitch = doShallow({ isLoading: true })
+    const toggleSwitch = doShallow({
+      isLoading: true,
+      spinnerLabel: 'Request is processing.',
+    })
     const spinner = toggleSwitch.find('Spinner')
     expect(spinner.prop('spinning')).toEqual(true)
   })

diff --git a/packages/ToggleSwitch/__tests__/__snapshots__/ToggleSwitch.spec.jsx.snap b/packages/ToggleSwitch/__tests__/__snapshots__/ToggleSwitch.spec.jsx.snap
@@ -75,7 +75,6 @@ exports[`ToggleSwitch renders 1`] = `
   label="label"
   name="name"
   onClick={[MockFunction]}
-  spinnerLabel="Request is processing."
   toolTipCopy="en"
   value="value"
 >
@@ -170,7 +169,6 @@ exports[`ToggleSwitch renders 1`] = `
                 dangerouslyHideVisibleLabel={false}
                 fullScreen={false}
                 inline={true}
-                label="Request is processing."
                 size="small"
                 spinning={false}
                 tag="span"