Skip to content

Commit

Permalink
refactor(core-notification): fix close position, correct docs typo
Browse files Browse the repository at this point in the history
  • Loading branch information
marcod1419 committed Oct 5, 2018
1 parent b2b7801 commit 0194d78
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
Binary file modified e2e/output/components/Notification/baseline/chrome_headless.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 6 additions & 5 deletions packages/Notification/Notification.md
Expand Up @@ -13,10 +13,10 @@ By default, notifications will be displayed in the `instructional` variant.

### Usage criteria

* The message of a notification must be text content only. You may use text-based styling such as bold text or links. Do
- The message of a notification must be text content only. You may use text-based styling such as bold text or links. Do
not use other complex components or paragraphs.
* Use complete sentences, while keeping the content succinct.
* Dismissible notifications should only be used for branded or general style notifications where there is no action needed from the user.
- Use complete sentences, while keeping the content succinct.
- Dismissible notifications should only be used for branded or general style notifications where there is no action needed from the user.

### Communicating with notifications

Expand Down Expand Up @@ -50,13 +50,14 @@ bold to indicate its importance.**
```jsx { "props": { "className": "docs_full-width-playground" } }
<Notification variant="error">
Looks like our registration system is temporarily down. You’ll need to come back another time to
register for My Account. In the meantime, return to <Link href="http://telus.com">TELUS.com</Link>.
register for My Account. In the meantime, return to <Link href="http://telus.com">TELUS.com</Link>
.
</Notification>
```

### Dismissible

Use the `dismissible` prop to allow users to dismiss the `Notification` at any time. The `dismissible` prop must be used together with the `dismissibleA11yLabel` to remain accessibile. Once dismissed, the `Notification` is removed from the DOM.
Use the `dismissible` prop to allow users to dismiss the `Notification` at any time. The `dismissible` prop must be used together with the `dismissibleA11yLabel` to remain accessible. Once dismissed, the `Notification` is removed from the DOM.

```jsx { "props": { "className": "docs_full-width-playground" } }
<Notification variant="branded" dismissible dismissibleA11yLabel="Close">
Expand Down
2 changes: 1 addition & 1 deletion packages/Notification/Notification.modules.scss
Expand Up @@ -30,6 +30,6 @@

.dismiss {
position: absolute;
top: 0.5rem;
top: 0.8rem;
right: 1rem;
}

0 comments on commit 0194d78

Please sign in to comment.