Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Custom options #701

Closed
theetrain opened this issue Jul 25, 2018 · 14 comments
Closed

[Select] Custom options #701

theetrain opened this issue Jul 25, 2018 · 14 comments
Labels
owner: core team item created by tds member priority: medium Medium priority items to be taken on by the core team or contributors, next in queue. status: reviewed item that has been reviewed by the core team and is ready for action type: enhancement enhancement or new requests

Comments

@theetrain
Copy link
Contributor

Description

The core-select component currently uses browser-specific 'option' interfaces for each <option>. There are two drawbacks:

  1. Depending on the browser you are using, the options' aesthetic differs from the branded Select
  2. Options can only have a single

See #484

Recommendation

Design review needed
Provide a prop interface that accepts different types of content.

Potential use cases:

  • Multi-line options
  • Options with headings
  • Filterable options

Designs

Design needed

Meta

  • TDS version: all
  • Willing to develop solution: Yes
  • Has workaround: No
  • High impact: Yes
@theetrain theetrain added type: enhancement enhancement or new requests status: review needed an item that needs to triaged or looked into labels Jul 25, 2018
@lucylist lucylist changed the title [Select] Branded options [Select] Custom options Jul 25, 2018
@jraff
Copy link
Contributor

jraff commented Aug 1, 2018

@aneesh-datta @ah-arch and Apurv Do you already have this designed? If so, please work with us to have this added to core.

@jraff jraff added status: design review 🎨 Requires design intent or review by design leads priority: low Low priority items or nice-to-have, we encourage contributions and removed status: review needed an item that needs to triaged or looked into labels Aug 1, 2018
@ah-arch
Copy link
Contributor

ah-arch commented Aug 1, 2018

Our previous design looks different from the design in the screenshot: #484 (comment)
(The closed state has two lines and the selected state has a checkmark)

@theetrain
Copy link
Contributor Author

@Berjesty please include this new design for Select in an upcoming design review.

@lucylist
Copy link
Contributor

design is yet to be resolved. the previous designs weren't accessible and we need align on the treatment. i think the consensus was that it'd be purple highlight with a bold text.
screenshot 2018-08-14 14 20 02
screenshot 2018-08-14 14 20 13

@jraff
Copy link
Contributor

jraff commented Sep 4, 2018

@Berjesty and her team do not have cycles to design this.

@Christina-Lo
Copy link
Contributor

@Berjesty is there anyone I can get the working file off of?

@lucylist
Copy link
Contributor

lucylist commented Sep 4, 2018

@Christina-Lo .. @apurv has the design files

@theetrain
Copy link
Contributor Author

@lucylist will take this to design review

@theetrain theetrain added priority: medium Medium priority items to be taken on by the core team or contributors, next in queue. and removed priority: low Low priority items or nice-to-have, we encourage contributions labels Sep 5, 2018
@ah-arch
Copy link
Contributor

ah-arch commented Sep 5, 2018

This is the sample code from a previous project:
https://github.com/telus/business-requests/tree/master/ui/src/components/base/forms/Dropdown

It has been developed as a redux-form component, i.e. expects the input and meta props.
And it accepts a list of options with custom content.

@Christina-Lo
Copy link
Contributor

This has been backlogged

@lucylist
Copy link
Contributor

lucylist commented Sep 19, 2018 •
edited
Loading

has been design reviewed and component looks good as is to be modified into tds-core. we will bold the hover state text.

TDS-core team to take this and enhance the current select component
https://telusdigital.atlassian.net/browse/TDS-957

@theetrain theetrain added status: reviewed item that has been reviewed by the core team and is ready for action and removed status: design review 🎨 Requires design intent or review by design leads labels Sep 19, 2018
@marcod1419
Copy link
Contributor

Hey there! Just a quick followup: this is still backlogged in our team's JIRA board. If anyone would like to see this prioritized, please let us know!

@marcod1419 marcod1419 added owner: core team item created by tds member and removed owner: core team item created by tds member labels Oct 24, 2018
@varunj90 varunj90 mentioned this issue Nov 6, 2018
Closed
@varunj90
Copy link
Contributor

varunj90 commented Nov 6, 2018

@telus-kyri issue mentioned in community - telus/tds-community#131 needs to be addressed

@theetrain theetrain added the owner: core team item created by tds member label Nov 28, 2018
@nadaltelus
Copy link
Contributor

Closing the issue due to lack of activity. If surfaced again, will consider as input for the new DS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
owner: core team item created by tds member priority: medium Medium priority items to be taken on by the core team or contributors, next in queue. status: reviewed item that has been reviewed by the core team and is ready for action type: enhancement enhancement or new requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@jraff @varunj90 @ah-arch @marcod1419 @theetrain @lucylist @Berjesty @Christina-Lo @nadaltelus