Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlexGrid Row looks expanded vertically in IE11 #783

Closed
hamedmam opened this issue Nov 2, 2018 · 4 comments
Closed

FlexGrid Row looks expanded vertically in IE11 #783

hamedmam opened this issue Nov 2, 2018 · 4 comments
Labels
low hanging fruit 🍒 Low effort, good first issue owner: core team item created by tds member priority: medium Medium priority items to be taken on by the core team or contributors, next in queue. status: completed ✅ An item that has been closed, due to its completion type: defect 🐛 bugs or defects

Comments

@hamedmam
Copy link
Contributor

hamedmam commented Nov 2, 2018 •
edited by theetrain

Description

  • FlexGrid issue with IE 11. When an image is wrapped inside FlexGrid.Col, it causes whitespace to appear above and below the FlexGrid parent.

Reproduction Steps

  • We made a temporary fix to site-builder, I am not able to reproduce at this point but wrapping the image in a FlexGrid.Col should reproduce the issue in IE 11

Meta

  • TDS version: v2.2.0
  • Willing to develop solution: No, since @theetrain is aware of fix I would kindly ask TDS team as I am currently overloaded with CPP work
  • Has workaround: Yes
  • High impact: Yes
@hamedmam hamedmam added the priority: high High priority items, users are affected, and the core team will prioritize label Nov 2, 2018
@triage-new-issues triage-new-issues bot removed the triage label Nov 2, 2018
@hamedmam hamedmam removed the priority: high High priority items, users are affected, and the core team will prioritize label Nov 2, 2018
@theetrain theetrain added type: enhancement enhancement or new requests priority: medium Medium priority items to be taken on by the core team or contributors, next in queue. status: reviewed item that has been reviewed by the core team and is ready for action labels Nov 19, 2018
@marcod1419
Copy link
Contributor

Hey @hamedmam, would you be able to provide more detailed reproduction steps? Specifically naming which image component causes this issue. As it is, I can't reproduce this. Thanks!

@theetrain theetrain added type: defect 🐛 bugs or defects and removed type: enhancement enhancement or new requests labels Nov 28, 2018
@theetrain
Copy link
Contributor

@hamedmam and I had a conversation. On IE11, the issue gets resolved when you add flex-shrink: 0; to the <FlexGrid.Row /> component.

The core team will get around to this, though contributions are welcome!

@theetrain theetrain added the low hanging fruit 🍒 Low effort, good first issue label Nov 28, 2018
@hamedmam
Copy link
Contributor Author

@marcod1419 I am sorry I missed your ping here, we already discussed the details with Enrico, if you need more details please let me know

@theetrain theetrain added status: in progress item in progress. owner: core team item created by tds member and removed status: reviewed item that has been reviewed by the core team and is ready for action labels Dec 10, 2018
theetrain added a commit that referenced this issue Dec 10, 2018
@theetrain
fix(core-flex-grid): apply flex-shrink 0 to FlexGrid.Row
8152f1f 
See #783
@theetrain theetrain mentioned this issue Dec 10, 2018
Merged
2 tasks
jraff pushed a commit that referenced this issue Dec 13, 2018
@theetrain @jraff
fix(core-flex-grid): apply flex-shrink 0 to FlexGrid.Row
326c99b 
See #783
@marcod1419
Copy link
Contributor

This is fixed on the latest version of FlexGrid! @hamedmam

@marcod1419 marcod1419 added status: completed ✅ An item that has been closed, due to its completion and removed status: in progress item in progress. labels Dec 14, 2018
jraff pushed a commit that referenced this issue Dec 17, 2018
@theetrain @jraff
fix(core-flex-grid): apply flex-shrink 0 to FlexGrid.Row
b7c2b70 
See #783
@kretzm kretzm mentioned this issue Feb 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low hanging fruit 🍒 Low effort, good first issue owner: core team item created by tds member priority: medium Medium priority items to be taken on by the core team or contributors, next in queue. status: completed ✅ An item that has been closed, due to its completion type: defect 🐛 bugs or defects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcod1419 @theetrain @hamedmam