drop extension / update crd #147
Conversation
| impl Default for Extension { | ||
| fn default() -> Self { | ||
| Extension { | ||
| name: "pg_stat_statements".to_owned(), | ||
| version: "1.9".to_owned(), | ||
| enabled: true, | ||
| schema: "postgres".to_owned(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
| impl Default for Extension { | |
| fn default() -> Self { | |
| Extension { | |
| name: "pg_stat_statements".to_owned(), | |
| version: "1.9".to_owned(), | |
| enabled: true, | |
| schema: "postgres".to_owned(), | |
| } | |
| } | |
| } |
I think the default should be an empty vec.
There was a problem hiding this comment.
Whats the basis for this being empty? This is the default method and it is explicit. You only gets used if you're calling ::Default().
There was a problem hiding this comment.
What's an example case for using this? I could see us using it as a default CRD value if we wanted this extension enabled whenever the user provides nothing in spec.extensions (like you had previously configured), but we want that to be empty in that case.
There was a problem hiding this comment.
I use ::Default() a lot in tests or wherever I want to construct a default set of values for struct.
There was a problem hiding this comment.
default_extensions is an empty vec regardless of implementing Default on the Extension
Co-authored-by: Ian Stanton <ian@coredb.io>
Co-authored-by: Ian Stanton <ian@coredb.io>
Co-authored-by: Ian Stanton <ian@coredb.io>
* Enable CNPG by default * pgmq enabled on initial creation * adjust tests * Fix tests * fmt * Fix race condition
Operator creates/drops postgres extensions.
Updated the CRD for extensions to be a list of objects, instead of a list of strings. Each object has as attribute:
enabled. Operator will use that attribute to switch its behavior.