[COR-155] 'coredb install' to install operator #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmiller609
commented
Jan 20, 2023
Comment on lines
+88
to
+92
| - name: Check CRD is updated in the yaml directory | ||
| run: | | ||
| set -xe | ||
| cargo run --bin crdgen > yaml/crd.yaml | ||
| git diff --exit-code yaml/crd.yaml |
There was a problem hiding this comment.
this part will fail if CRD definition is changed but yaml directory not updated
sjmiller609
commented
Jan 20, 2023
sjmiller609
commented
Jan 20, 2023
coredb-operator/Dockerfile
Outdated
Comment on lines
1
to
15
| FROM clux/muslrust:stable AS builder | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN cargo build --release | ||
|
|
||
| FROM alpine:latest | ||
|
|
||
| RUN adduser -D nonroot | ||
|
|
||
| COPY --chown=nonroot:nonroot --from=builder target/x86_64-unknown-linux-musl/release/controller /app/controller | ||
| COPY --chown=nonroot:nonroot --from=builder target/x86_64-unknown-linux-musl/release/crdgen /app/crdgen | ||
|
|
||
| USER nonroot | ||
|
|
There was a problem hiding this comment.
Although rust compiles to a binary, by default that binary has dependencies in the system like openssl and libc. If we build with MUSL we can avoid that - like clux did in the controller example.
sjmiller609
commented
Jan 20, 2023
| @@ -86,7 +86,7 @@ spec: | |||
| serviceAccountName: coredb-controller | |||
| containers: | |||
| - name: coredb-controller | |||
| image: localhost:5001/controller:ac593af6da990c911652c6e35fb777f36498d6dc | |||
| image: sjmiller609/coredb-operator:latest | |||
There was a problem hiding this comment.
replace this with quay when ian is back
sjmiller609
requested review from
ryw,
ianstanton and
ChuckHend
as code owners
ChuckHend
approved these changes
Jan 20, 2023
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
added a commit
that referenced
this pull request
Dec 5, 2023
sjmiller609
pushed a commit
that referenced
this pull request
Dec 5, 2023
* wip restart event * change unhandled message * add sts restart fn * handle restart event * add test * fix test * handle reporting state event * cleanup * minor refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coredb-install-demo.mov