Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for extension version #596

Merged
merged 5 commits into from
Mar 1, 2024
Merged

adds support for extension version #596

merged 5 commits into from
Mar 1, 2024

Conversation

shahadarsh
Copy link
Collaborator

  • adds support to specify extension version in tembo.toml
  • if the version not specified gets it from trunk registry

sjmiller609
sjmiller609 requested changes Feb 29, 2024
View reviewed changes
tembo-cli/src/cmd/apply.rs Outdated
version: None,
enabled: extension.enabled,
});
let version = Runtime::new()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the typical approach is just to make the parent function async, then use await.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I can do that but then I will have to go all the way to the top function and add async/await for all. Do you think that's better?

tembo-cli/src/cmd/apply.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/apply.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/apply.rs Outdated Show resolved Hide resolved
@shahadarsh shahadarsh merged commit 8feb20c into main Mar 1, 2024
7 checks passed
@shahadarsh shahadarsh deleted the extension-version branch March 1, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shahadarsh @sjmiller609