adds stack as alias for stack_type, deny_unknown_fields #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shahadarsh
commented
Mar 4, 2024
shahadarsh
commented
- stack as alias for stack_type
- shows below error for unknown field:
shahadarsh
requested review from
vrmiguel,
DarrenBaldwin07 and
sjmiller609
as code owners
shahadarsh
changed the title
sjmiller609
approved these changes
Mar 4, 2024
tembo-cli/src/cmd/top.rs
Outdated
| @@ -34,7 +34,7 @@ pub struct MetricsResponse { | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug)] | |||
| pub struct MetricsData { | |||
| pub resultType: String, | |||
There was a problem hiding this comment.
I think this change effects parsing, so please check still works and maybe can add a test for tembo top in the test against cloud. To fix the lint issue, it’s possible to use serde macros to parse the value as something different than the variable name.
There was a problem hiding this comment.
Oh yes.. I'm gonna revert the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.