Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses alt base image based on the stack for local #627

Merged
merged 4 commits into from
Mar 7, 2024
Merged

uses alt base image based on the stack for local #627

merged 4 commits into from
Mar 7, 2024

Conversation

shahadarsh
Copy link
Collaborator

No description provided.

sjmiller609
sjmiller609 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to include a test that starts on each pg version the standard stack, i.e. matrix build for local, minimal example

@shahadarsh
Copy link
Collaborator Author

it would be nice to include a test that starts on each pg version the standard stack, i.e. matrix build for local, minimal example

Yup. Working on tests in the next PR for local & cloud.

@shahadarsh shahadarsh merged commit 8c9e8f9 into main Mar 7, 2024
7 checks passed
@shahadarsh shahadarsh deleted the alt-base-image branch March 7, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shahadarsh @sjmiller609