Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kubernetes 429 error requeue with jitter #696

Merged
merged 1 commit into from
Apr 4, 2024
Merged

add kubernetes 429 error requeue with jitter #696

merged 1 commit into from
Apr 4, 2024

Conversation

nhudson
Copy link
Collaborator

@nhudson nhudson commented Apr 4, 2024

Add error handling in the client to requeue differently when a 429 is returned back from the server.

  • Added two new tests to mock the Kubernetes API to test a 429 return code and a non 429 return code.

Fixes: PLAT-497

@nhudson nhudson self-assigned this Apr 4, 2024
sjmiller609
sjmiller609 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very elegant

@nhudson nhudson merged commit 6802e9e into main Apr 4, 2024
9 checks passed
@nhudson nhudson deleted the nhudson/PLAT-497 branch April 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

@ChuckHend ChuckHend Awaiting requested review from ChuckHend ChuckHend is a code owner

Assignees

@nhudson nhudson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhudson @sjmiller609