Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: error message with duplicate tembo login using org ID and profile name #703

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Fix: error message with duplicate tembo login using org ID and profile name #703

merged 8 commits into from
Apr 10, 2024

Conversation

joshuajerin
Copy link
Contributor

No description provided.

sjmiller609
sjmiller609 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@sjmiller609 sjmiller609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just think the user-facing wording could be improved, I gave some suggestions

tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
tembo-cli/src/cmd/login.rs Outdated Show resolved Hide resolved
joshuajerin and others added 4 commits April 10, 2024 09:52
@joshuajerin @sjmiller609
Update tembo-cli/src/cmd/login.rs
bb4d25a 
Co-authored-by: Steven Miller <sjmiller609@gmail.com>
@joshuajerin @sjmiller609
Update tembo-cli/src/cmd/login.rs
9f00e5e 
Co-authored-by: Steven Miller <sjmiller609@gmail.com>
@joshuajerin @sjmiller609
Update tembo-cli/src/cmd/login.rs
faa13ec 
Co-authored-by: Steven Miller <sjmiller609@gmail.com>
@joshuajerin @sjmiller609
Update tembo-cli/src/cmd/login.rs
232dc18 
Co-authored-by: Steven Miller <sjmiller609@gmail.com>
@sjmiller609 sjmiller609 mentioned this pull request Apr 10, 2024
Merged
@joshuajerin joshuajerin merged commit 2686a3f into main Apr 10, 2024
3 checks passed
@joshuajerin joshuajerin deleted the cli-fix_login branch April 10, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@shahadarsh shahadarsh Awaiting requested review from shahadarsh shahadarsh is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

@DarrenBaldwin07 DarrenBaldwin07 Awaiting requested review from DarrenBaldwin07 DarrenBaldwin07 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuajerin @sjmiller609