Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Stacks ComputeTemplate with ComputeConstraint #760

Merged
merged 3 commits into from
May 6, 2024
Merged

Replace Stacks ComputeTemplate with ComputeConstraint #760

merged 3 commits into from
May 6, 2024

Conversation

ChuckHend
Copy link
Collaborator

Instead of specifying all possible CPU and Mem combinations, the Stack spec will just specify a constraint. for example, a minimum CPU and Memory amount.

@ChuckHend ChuckHend mentioned this pull request May 6, 2024
Merged
@ChuckHend ChuckHend marked this pull request as ready for review May 6, 2024 20:29
jasonmp85
jasonmp85 requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@jasonmp85 jasonmp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to pushback, but I don't think max is necessary if it isn't presently used and is also not implemented in the code that applies constraints.

tembo-operator/src/stacks/types.rs Outdated Show resolved Hide resolved
tembo-operator/src/stacks/types.rs Show resolved Hide resolved
@ChuckHend ChuckHend requested a review from jasonmp85 May 6, 2024 20:55
@ChuckHend ChuckHend merged commit 20c8813 into main May 6, 2024
9 checks passed
@ChuckHend ChuckHend deleted the SPAE-154-0 branch May 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmp85 jasonmp85 jasonmp85 approved these changes

@sjmiller609 sjmiller609 sjmiller609 approved these changes

@nhudson nhudson Awaiting requested review from nhudson nhudson is a code owner

@ianstanton ianstanton Awaiting requested review from ianstanton ianstanton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChuckHend @jasonmp85 @sjmiller609