Add Region to CF Bucket Endpoint URL #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Stanton <ian@tembo.io>
|
This would require us to update conductor's IAM policy, so I'll have it fall back to the original format if region is |
Signed-off-by: Ian Stanton <ian@tembo.io>
ianstanton
requested review from
sjmiller609,
nhudson and
ChuckHend
as code owners
nhudson
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buckets in AWS GovCloud (and possibly other regions) require the region in the bucket endpoint URL. Add this to CloudFormation template URL.
If region is
us-east-1, fall back to original URL format to avoid extra changes cloud.