Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add podmonitor to coredb spec #809

Merged
merged 21 commits into from
May 29, 2024
Merged

add podmonitor to coredb spec #809

merged 21 commits into from
May 29, 2024

Conversation

ChuckHend
Copy link
Collaborator

@ChuckHend ChuckHend commented May 28, 2024

adds metrics to AppService spec:

app_services:
  metrics:
    path: /metrics
    port: 3000

When this is present in the CoreDB Spec, Tembo Operator deploys a PodMonitor for the specified AppService, which will result in scraping metrics from the specified port and path.

The PodMonitor is owned by the Service associated with the AppService, so when the AppService is deleted, so is the Service and the PodMonitor.

@ChuckHend ChuckHend marked this pull request as ready for review May 28, 2024 21:47
Copy link
Collaborator

@nhudson nhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to bump the controller version as well.

@ChuckHend ChuckHend merged commit d507f10 into main May 29, 2024
15 checks passed
@ChuckHend ChuckHend deleted the SPAE-198 branch May 29, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants