Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt tempesta-tech.com in LXC container test #602

Merged
merged 19 commits into from
Jun 20, 2024
Merged

Adopt tempesta-tech.com in LXC container test #602

merged 19 commits into from
Jun 20, 2024

Conversation

mbabitski-t
Copy link
Contributor

@mbabitski-t mbabitski-t commented Mar 29, 2024 •
edited by RomanBelozerov
Loading

This PR resolves #507

  • add LXC backend for container testing
  • automatic LXC proxy setup and teardown
  • backend can optionally make a pre-test snapshot and restore the container to it's previous stage
  • spin up a staging site container of tempesta-tech.com
  • test the site with common interaction flow: get the main page, fetch list of blog posts, login as admin, create a blog post, check that the post exists, login as user, add a comment, login as admin, approve the comment and check that it appeared on the blog post page.

@RomanBelozerov RomanBelozerov force-pushed the mb-507-lxc branch 2 times, most recently from 90d007e to e3236f8 Compare May 6, 2024 12:35
@RomanBelozerov RomanBelozerov marked this pull request as ready for review May 9, 2024 09:20
const-t
const-t requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@const-t const-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we test how caching works with WP? For instance, add comment to blog post and check if it was added and post was updated. And edit blog post from admin panel then check that changes applied to post and users can see them.

setup.sh Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
t_sites/test_tempesta_tech.py Outdated Show resolved Hide resolved
krizhanovsky
krizhanovsky approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krizhanovsky
krizhanovsky requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments on the caching behavior.

t_sites/test_tempesta_tech.py Show resolved Hide resolved
t_sites/test_tempesta_tech.py Show resolved Hide resolved
const-t
const-t reviewed Jun 6, 2024
View reviewed changes
t_stress/test_wordpress.py Outdated Show resolved Hide resolved
krizhanovsky
krizhanovsky approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mbabitski-t and others added 14 commits June 19, 2024 14:54
@mbabitski-t @RomanBelozerov
Add LXC testing backend
335b8a5
@mbabitski-t @RomanBelozerov
Add LXC container healthcheck
df12b27
@mbabitski-t @RomanBelozerov
Remove unused variables
436f6d7
@mbabitski-t @RomanBelozerov
Remove reference to another branch
6643d16
@mbabitski-t @RomanBelozerov
Add LXC server factory
df0f266
@mbabitski-t @RomanBelozerov
Remove unused code
a27a055
@mbabitski-t @RomanBelozerov
LXC pretest snapshot
8801fc5
@mbabitski-t @RomanBelozerov
Semi-working site test
5154838
@RomanBelozerov
rework LXCServer:
b654659 
- subprocess changed to `node.run_cmd`;
- the waiting moved from run_start to wait_for_connection;
- removed all optional functions for this class. They are not necessary, but it makes the code more difficult. We don't plan to create other containers or multiple ports.
@RomanBelozerov
fix and add tests for tempesta-tech with LXCServer, update default te…
0abd3f8 
…st configs
@RomanBelozerov
remove docker and tests using docker.
fbc7402
@RomanBelozerov
add tempesta-tech as git submodule
576f75e
@RomanBelozerov
remove docker-compose backend, update README.
73025d5
@RomanBelozerov
typo fix and update tests_disabled_* files
b5087d7
@RomanBelozerov
change link for tempesta-tech module to https because currently CI …
e7fcf41 
…uses creds with login/password
@RomanBelozerov
change IP for cache_purge_acl because by default the client IP in t…
72eb9f3 
…est framework is 127.0.0.2
@RomanBelozerov
add test case
5736b6c 
- add a new post page;
- add a new comment to this page;
- update cache;
- cache the comment is present on this page;
@RomanBelozerov
fix setup.sh
558ca0a
@RomanBelozerov
typo fix and update comment
a67ad26
@RomanBelozerov RomanBelozerov merged commit b7351d0 into master Jun 20, 2024
1 check failed
@RomanBelozerov RomanBelozerov deleted the mb-507-lxc branch June 20, 2024 07:20
enuribekov-tempesta pushed a commit that referenced this pull request Jul 3, 2024
@mbabitski-t @RomanBelozerov @enuribekov-tempesta
Adopt tempesta-tech.com in LXC container test (#602)
cc03aba 
* Add LXC testing backend

* Add LXC container healthcheck

* Remove unused variables

* Remove reference to another branch

* Add LXC server factory

* Remove unused code

* LXC pretest snapshot

* Semi-working site test

* rework LXCServer:
- subprocess changed to `node.run_cmd`;
- the waiting moved from run_start to wait_for_connection;
- removed all optional functions for this class. They are not necessary, but it makes the code more difficult. We don't plan to create other containers or multiple ports.

* fix and add tests for tempesta-tech with LXCServer, update default test configs

* remove docker and tests using docker.

* add tempesta-tech as git submodule

* remove docker-compose backend, update README.

* typo fix and update tests_disabled_* files

* change link for tempesta-tech module to `https` because currently CI uses creds with login/password

* change IP for `cache_purge_acl` because by default the client IP in test framework is 127.0.0.2

* add test case
- add a new post page;
- add a new comment to this page;
- update cache;
- cache the comment is present on this page;

* fix setup.sh

* typo fix and update comment

---------

Co-authored-by: Roman <rb@tempesta-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBelozerov RomanBelozerov RomanBelozerov left review comments

@EvgeniiMekhanik EvgeniiMekhanik EvgeniiMekhanik left review comments

@krizhanovsky krizhanovsky krizhanovsky approved these changes

@const-t const-t const-t approved these changes

Assignees

@RomanBelozerov RomanBelozerov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt tempesta-tech.com in LXC container test
5 participants
@mbabitski-t @krizhanovsky @const-t @RomanBelozerov @EvgeniiMekhanik