-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt tempesta-tech.com
in LXC container test
#602
Conversation
90d007e
to
e3236f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test how caching works with WP? For instance, add comment to blog post and check if it was added and post was updated. And edit blog post from admin panel then check that changes applied to post and users can see them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
76473cf
to
7a858e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments on the caching behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- subprocess changed to `node.run_cmd`; - the waiting moved from run_start to wait_for_connection; - removed all optional functions for this class. They are not necessary, but it makes the code more difficult. We don't plan to create other containers or multiple ports.
…uses creds with login/password
…est framework is 127.0.0.2
- add a new post page; - add a new comment to this page; - update cache; - cache the comment is present on this page;
1128c51
to
a67ad26
Compare
This PR resolves #507
tempesta-tech.com