Dl issue 182 #573
Closed
Dl issue 182 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired to ensure the wrapper is working properly
| return ids[n];} | ||
|
|
||
| #define AVX_STRID_2(n) do {\ | ||
| static const int ids[9] = {\ |
There was a problem hiding this comment.
The same as above. Need to use ids[10] or ids[] as there are 10 elements in array.
… macros in avx_routines.h;\n minor bugfixes;
|
The code doesn't comply our coding style, please adjust the style. |
|
What's going on in |
| } | ||
|
|
||
| fseek(source, 0, SEEK_END); | ||
| size_t len = ftell(source); |
There was a problem hiding this comment.
usually fstat(2) is used to get file size. Moreover, since you set file pointer using fseek() following fread() doesn't read any data and your test doesn't test anything.
|
Poorly done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tempesta parser was cut from main source tree and supporting code was refactored for testing in standalone environment. Tempesta parser was patched with AVX insertions in performance critical places, but otherwise remains intact and can be transferred back to it's original position.