-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDo: TypeScript #1
Comments
Are PR's welcome for this? |
@azdanov Usually I would say yes in a heartbeat, but I have it almost done. Definitely can look it over and make tweaks in a PR once I have it merged. 😄 |
@azdanov https://github.com/Templarian/MaterialDesign-React/blob/master/src/Icon.tsx Not even tested or compiled yet. Just committing a rough draft. It's really close to your PR. Busy tonight working on some other stuff, but will have more time this weekend. |
ToDo: Need to add the |
@azdanov Okay, so I've ran into a really dumb bug/issue. I can't get the Basic example: The Kind of giving up for now and moving on to adding icons and will look into this shortly. Any help would be appreciated. Attached my sample app. |
Add this to externals: {
react: "commonjs react",
"prop-types": "commonjs prop-types"
} |
That worked. Awesome! |
Probably same issue as React. Facebook still uses commonjs. |
I'm wondering if webpack is needed. Since this is used in By itself EDIT: Forgot to mention some benefits:
|
Yea, the |
Closing this and working on updating the build to use TSC with a new issue. @azdanov Can you do a PR and add a |
Rewrite this component in TypeScript 3 and include the definition files like we do for
@mdi/js
.The text was updated successfully, but these errors were encountered: