Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 3.0.12 Error > Attempt to modify property "links" on false #623

Closed
Joomlaplates opened this issue Mar 30, 2024 · 12 comments
Closed

Since 3.0.12 Error > Attempt to modify property "links" on false #623

Joomlaplates opened this issue Mar 30, 2024 · 12 comments
Labels
bug Something isn't working Issue SOLVED!

Comments

@Joomlaplates
Copy link
Collaborator

After update the Astroid to 3.0.12 I got an error when i want to setup the Template settings

Joomla 5.0.3 and PHP 8.3
Attempt to modify property "links" on false
Bildschirmfoto2024-03-28um15 36 07

Anybody know what it is?
Thanks

@sonvnn
Copy link
Member

sonvnn commented Mar 30, 2024

It's problem from Menu Assignment. I will release a quick fix on Monday. Solution is revert to 3.0.11

@sonvnn
Copy link
Member

sonvnn commented Apr 1, 2024

Hi @Joomlaplates

May you send me your admin account? I need check it on your server.

Thanks & Best Regards,
Sonny

@Joomlaplates
Copy link
Collaborator Author

With V3 Astroid I still got the issue
issue

@sonvnn
Copy link
Member

sonvnn commented Apr 1, 2024

May you send me the admin of your site? I will check it.

Best regards,
Sonny

@Joomlaplates
Copy link
Collaborator Author

I have send you already! Now again

@RedesMexico
Copy link

RedesMexico commented Apr 1, 2024

I have the same error with version 3.0.12, can I collaborate?

Following "sonvnn", I have executed the 36 additions and 34 deletions of the Helper.php file. However the error remains the same.

@sonvnn
Copy link
Member

sonvnn commented Apr 2, 2024

I have send you already! Now again

I am sorry! I still haven't received your email yet. Can you send me again via sonlv@templaza.com?

@RedesMexico Yes, please send me your admin account via sonlv@templaza.com. I will help you check it.

@sonvnn
Copy link
Member

sonvnn commented Apr 2, 2024

@Joomlaplates @RedesMexico I added some conditions to handle exceptions of Menu Links at 85f437c. Please help me download v3-branch and retest it.

As soon as you confirm this issue gone. I will release v3.0.13

@RedesMexico
Copy link

Ok I will test again with the new changes in 85f437c.

@RedesMexico
Copy link

RedesMexico commented Apr 2, 2024

Hello

The line 421 is 1 addition ? --- if ($link->level !== 0) {

@sonvnn
Copy link
Member

sonvnn commented Apr 2, 2024

@RedesMexico Just download https://github.com/templaza/astroid-framework/archive/refs/heads/v3.zip and install to your Joomla extension.

@Joomlaplates
Copy link
Collaborator Author

Hello Sonny,
yes its working now with new Astroid v3.
Thank you!! Greatings Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Issue SOLVED!
Projects
None yet
Development

No branches or pull requests

4 participants