Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color mode switcher always visible in Sticky Header #660

Closed
GeoffroyVD opened this issue Apr 23, 2024 · 2 comments · Fixed by #673
Closed

Color mode switcher always visible in Sticky Header #660

GeoffroyVD opened this issue Apr 23, 2024 · 2 comments · Fixed by #673

Comments

@GeoffroyVD
Copy link

GeoffroyVD commented Apr 23, 2024

The color mode switcher for (Light/Dark Theme) is always visible in the Sticky Header also when you define a module position of hidden or COM_MODULES_NONE. For Astroid Template Zero and Astroid Template Two

For my configuration with Astroid Template Zero it is coming twice in the Sticky Header when I define it in position topbar-2 or header-right like defined in Header section configuration.

See the different screenshots of the configurations.

Header section config
Sticky Header with color mode enabled
Header with color mode enabled

@sonvnn
Copy link
Member

sonvnn commented May 13, 2024

Dear @GeoffroyVD

Thanks for report issue. I fixed this at cbb319a

Please help me download v3-branch and re-test again.

Best Regards,
Sonny

@sonvnn sonvnn added this to the Version 3.0.15 milestone May 13, 2024
@sonvnn sonvnn linked a pull request May 13, 2024 that will close this issue
@GeoffroyVD
Copy link
Author

Dear @sonvnn,

It is working like expected.
Thanks for the quick fix of it.

THX,
@GeoffroyVD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants