PT-Gradient #127
Merged
PT-Gradient #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoin-dp-oneill
force-pushed
the
dev-v0.5
branch
from
9e250b8
to
91cea54
Compare
* Simplify functionality state_gradient and compute_gradient_and_dynamics * Overhall and simplify tutorial * Overhall code style (pylint) * Correct several doc strings * Add numdifftools in requirements_ci * Several more minor changes
gefux
requested changes
May 1, 2024
There was a problem hiding this comment.
Hi @eoin-dp-oneill.
Thank you for your contribution!
I've edited your code a bit in the last couple of days to make it ready for merging. I just pushed two commits to your branch implementing those changes.
One thing that I would need from you is to complete the two lines marked with '???' in gradients.py.
The compute_gradient_and_dynamics() function should a list of ndarrays (not tensornetwork.Node objects). However tensornetwork.Node.get_tensor() does not guarantee a specific order of axis when called without parameters. Could you (@eoin-dp-oneill) please specify the axes order and describe that order also in the docstring?
15 tasks
gefux
approved these changes
Jun 1, 2024
|
Thank you, and congratulations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-Gradient
Here is a pull-request for the PT-Gradient code, with modifications according to feedback from Gerald et al.
tox -e py36(to runpytest) the code tests.tox -e style(to runpylint) the code style tests.tox -e docs(to runsphinx) generate the documentation./docs/pages/modules.rsthas been updated./docs/pages/api.rsthas been updated.There will be a separate pull request for the Performance Testing code.
Hope everything is acceptable here. Let me know if any other improvements/fixes could be made.
Best,
Eoin O.