Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance testing of degeneracy checking for PT generation #130

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

ewenlawrence
Copy link
Contributor

This pull request adds a performance benchmark for comparing generating process tensors with and without degeneracy checking, using a S_z coupling operator of varying spin size.

Pull Request Check List

  • The contribution has been discussed and agreed on in the Issue section.
  • Code contributions do its best to follow the zen of python.
  • The automated test are all positive:
    • tox -e py36 (to run pytest) the code tests.
    • tox -e style (to run pylint) the code style tests.
    • tox -e docs (to run sphinx) generate the documentation.
  • Added test for changed/added code.
  • API code contributions include input checks (defensive code).
  • API code contributions include helpful error messages.
  • The documentation has been updated:
    • docstring for all new functions/methods/classes/modules.
    • consistent style of all docstrings.
    • for new modules: /docs/pages/modules.rst has been updated.
    • for api contributions: /docs/pages/api.rst has been updated.
    • for api contributions: tutorials and examples have been updated.

@piperfw
Copy link
Collaborator

piperfw commented May 21, 2024

Hi @ewenlawrence, sorry hadn't noticed this sitting here. Thanks for putting your tests into a convenient format for us.

The generated plot doesn't look like the one currently in that paper, is the one in the paper a separate one you or Gerald have produced?

@piperfw piperfw self-assigned this May 21, 2024
@gefux gefux merged commit 2aaa779 into tempoCollaboration:dev-v0.5 Jun 1, 2024
@gefux
Copy link
Member

gefux commented Jun 1, 2024

Great, thank you! This closes #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants