Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protos to support Enhanced DescribeTaskQueue and rename ListWorkerVersioningRules to GetWorkerVersioningRules #153

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Update protos to support Enhanced DescribeTaskQueue and rename ListWorkerVersioningRules to GetWorkerVersioningRules #153

merged 4 commits into from
Mar 19, 2024

Conversation

carlydf
Copy link
Contributor

@carlydf carlydf commented Mar 19, 2024 •
edited

Describe what has changed in this PR

  1. Pulled in new changes to DescribeTaskQueueRequest from api repo
  2. Pulled in api repo rename of ListWorkerVersioningRules --> GetWorkerVersioningRules

Tell your future self why have you made these changes

  1. To prepare to implement the enhanced DescribeTaskQueue API
  2. To finish renaming List --> Get so that the versioning rule API uses verbs that match other uses of those verbs in our system

How did you test it?

Potential risks

@carlydf carlydf requested review from a team as code owners March 19, 2024 23:08
@carlydf carlydf merged commit d3c0855 into versioning-2 Mar 19, 2024
2 checks passed
@carlydf carlydf deleted the cdf/wv-describe-grpc branch March 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antlai-temporal antlai-temporal antlai-temporal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@carlydf @antlai-temporal