Update API cleanups #211
Merged
Update API cleanups #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing this API has show us some fixups that need to occur - Use update_id rather than update_token in commands - Consistenly use WorkflowUpdate rather than UpdateWorkflow for events, commands, and enums - remove "Rejection" from WorkflowUpdateRejectionDurabilityPreference so that the enum can be used in more places
alexshtin
approved these changes
Jul 28, 2022
Sushisource
approved these changes
Jul 28, 2022
The current PR makes changes to unstable APIs. There is no intent to preserve backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implementing this API has show us some fixups that need to occur
commands, and enums
that the enum can be used in more places
Why?
Naming predictability and reuse
Breaking changes
Very. But to an API that has not been released or implemented yet so doesn't matter.