Add continued_failure and last_completion_result to StartWorkflowExecution #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works because it goes direct to history, but we want to change it to go through frontend, so we need to be able to set them in the frontend request |
bergundy
approved these changes
Feb 10, 2023
yiminc
approved these changes
Feb 10, 2023
| @@ -174,6 +174,9 @@ message StartWorkflowExecutionRequest { | |||
| // The returned task will be marked as started and is expected to be completed by the specified | |||
| // `workflow_task_timeout`. | |||
| bool request_eager_execution = 17; | |||
| // These two fields are intended for internal use only. | |||
There was a problem hiding this comment.
Still worth to put some comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow these two fields to be set on new workflows at the frontend api level.
Why?
For the schedule feature, we need to be able to set these, but also want the rpc to go through the frontend. They don't have to be exposed anywhere else.
Breaking changes
No