Add namespace_delete_delay option to DeleteNamespaceRequest #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jan 12, 2024
| @@ -74,6 +75,9 @@ message DeleteNamespaceRequest { | |||
| // Only one of namespace or namespace_id must be specified to identify namespace. | |||
| string namespace = 1; | |||
| string namespace_id = 2; | |||
| // If provided, the deletion of namespace info will be delayed for given duration (0 means no delay). | |||
| // If not provided, use default delay configured in the cluster. | |||
| google.protobuf.Duration namespace_delete_delay = 3; | |||
There was a problem hiding this comment.
It is already in DeleteNamespaceRequest. I would call it just delay.
There was a problem hiding this comment.
delay may cause confusion that the whole deletion was delayed, which isn't the case (WF will be still deleted immediately).
alexshtin
approved these changes
Jan 12, 2024
Sushisource
approved these changes
Jan 12, 2024
Comment on lines
78
to
79
| // If provided, the deletion of namespace info will be delayed for given duration (0 means no delay). | ||
| // If not provided, use default delay configured in the cluster. |
There was a problem hiding this comment.
Suggested change
| // If provided, the deletion of namespace info will be delayed for given duration (0 means no delay). | |
| // If not provided, use default delay configured in the cluster. | |
| // If provided, the deletion of namespace info will be delayed for given duration (0 means no delay). | |
| // If not provided, the default delay configured in the cluster will be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
So we can override DeleteNamespaceNamespaceDeleteDelay dynamic config setting for deleting namespace info.
Breaking changes