Moving retry interval to ApplicationFailure per Yimins request. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jan 12, 2024
Comment on lines
1
to
2
| // The MIT License | ||
| // |
ast2023
force-pushed
the
sasha/api-update
branch
from
70506e0
to
2742103
Compare
cretz
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Since you're technically making a backwards incompatible change to our API, you'll have to disable the buf compatibility checker in this PR and re-enable it in another PR after you've merged this one. Right now CI will fail.
(marking approved as agreed, though I don't personally agree w/ this being on the error)
yiminc
approved these changes
Jan 12, 2024
ast2023
force-pushed
the
sasha/api-update
branch
from
92335d8
to
4eb9db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
retry delay interval was moved from ActivityFailed message to ApplicationFailure
Why?
Requested by Yimin
No