Add target_ prefix for CreateOrUpdateNexusIncomingServiceRequest fields #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM assuming open source only. Would like to set a general suggestion of namespace of all requests being field 1 for compat assistance for edge proxies, but since this is open source only it's not a big deal.
Can you confirm all workflowservice calls for Nexus are string namespace = 1?
dnr
approved these changes
Mar 11, 2024
I didn't add any more workflowservice RPCs, but the operatorservice outgoing registry RPCs all include a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
See title.
Why?
Server considers requests with a namespace field as being scoped to that namespace which this request should be cluster scoped.
Breaking changes
Yes