Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding search attributes, do not remove already existing ones #401

Merged
merged 1 commit into from
Dec 12, 2023
Merged

When adding search attributes, do not remove already existing ones #401

merged 1 commit into from
Dec 12, 2023

Conversation

rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented Dec 12, 2023 •
edited

What was changed

When adding search attributes, do not remove already existing ones.

Why?

Allow adding search attributes in dual visibility setting.
The Server can handle already existing search attributes.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@rodrigozhou rodrigozhou requested review from alexshtin and a team December 12, 2023 18:16
@rodrigozhou rodrigozhou force-pushed the rodrigozhou/add-sa-already-exists branch from f30efc2 to 4aa5261 Compare December 12, 2023 19:38
@rodrigozhou rodrigozhou merged commit 8fe6482 into main Dec 12, 2023
17 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/add-sa-already-exists branch December 12, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeebswihart tdeebswihart tdeebswihart approved these changes

@alexshtin alexshtin Awaiting requested review from alexshtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rodrigozhou @tdeebswihart