Fix the "delete namespace" prompt #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were improperly lower-casing the user's input when asking them to confirm the namespace name, and then providing no feedback to the user if the name didn't match, leaving them with the false impression that the namespace was deleted even though we didn't even try.
josh-berry
changed the title
bergundy
reviewed
Jan 2, 2024
| } | ||
| fmt.Println() | ||
|
|
||
| if len(expectedInputs) == 0 { | ||
| return true | ||
| } | ||
|
|
||
| textLower := strings.ToLower(strings.TrimSpace(text)) | ||
| for _, expectedInput := range expectedInputs { |
There was a problem hiding this comment.
nit: can use https://pkg.go.dev/slices#Contains
There was a problem hiding this comment.
Same as below, I don't really want to make any more changes than absolutely necessary since this is a hotfix.
bergundy
reviewed
Jan 2, 2024
| @@ -303,7 +303,7 @@ func DeleteNamespace(c *cli.Context) error { | |||
|
|
|||
| promptMsg := color.Red(c, "Are you sure you want to delete namespace %s? Type namespace name to confirm:", ns) | |||
| if !common.Prompt(promptMsg, c.Bool(common.FlagYes), ns) { | |||
There was a problem hiding this comment.
We shouldn't print the prompt if the user wants to auto-confirm.
There was a problem hiding this comment.
We print both the prompt and response, which I think is okay for this hotfix. I don't really want to expand the scope of this PR since we're working on a rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were improperly lower-casing the user's input when asking them to confirm the namespace name, and then providing no feedback to the user if the name didn't match, leaving them with the false impression that the namespace was deleted even though we didn't even try.
Closes #405