Use go's native cross-compilation for binaries #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go supports native cross-compilation; there's no need to build in qemu
dnr
reviewed
Apr 1, 2024
There was a problem hiding this comment.
General questions:
- We were previously using released versions of cli. Now we're using a submodule. Are we planning to point it only to release tags? How do we manage that?
- Should we ensure that the server embedded in the cli is the same as the server in this image? If we do want to do that, how? go mod replace?
- Should we skip right to the new pre-release cli instead of the old-new one?
|
We can still attempt to point to only official releases.
The old-new cli never had an official non-preview release so this shouldn't be a breaking change. Only |
Pattern rules to the rescue
We should only point to official releases, I agree. And I'll file a ticket to swap to the pre-release new CLI as follow-up work |
We aren't guaranteed to have access to {} expansion
If you need to build and push locally remove the --set bit and change --load to --push
This cleans up how we specify its target
The arm64 dockerize binary keeps getting deleted by make
tdeebswihart
force-pushed
the
tds/build-externally
branch
from
00a0c5b
to
98c025d
Compare
dnr
reviewed
Apr 2, 2024
Co-authored-by: David Reiss <david@temporal.io>
dnr
approved these changes
Apr 2, 2024
alexshtin
approved these changes
Apr 2, 2024
tdeebswihart
added a commit
that referenced
this pull request
Apr 4, 2024
1. Cross-compilation is done outside of the docker container, and images are copying in pre-built binaries 2. All external dependencies are vendored using submodules instead of cloning (dockerize) or curling (cli) Building this container now takes ~1m locally instead of over an hour on my aarch64 laptop. I tested this locally by running `make build test`
tdeebswihart
added a commit
that referenced
this pull request
Apr 4, 2024
1. Cross-compilation is done outside of the docker container, and images are copying in pre-built binaries 2. All external dependencies are vendored using submodules instead of cloning (dockerize) or curling (cli) Building this container now takes ~1m locally instead of over an hour on my aarch64 laptop. I tested this locally by running `make build test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Building this container now takes ~1m locally instead of over an hour on my aarch64 laptop.
Checklist
I tested this locally by running
make build test