Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET docs #2799

Merged
merged 2 commits into from
May 6, 2024
Merged

.NET docs #2799

merged 2 commits into from
May 6, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented May 3, 2024

What does this PR do?

Fill in scaffolding for .NET docs. Notes:

  • Not looking for English editorial review in PR. Rather, we're hoping it can be copy/edited by a docs team member.
  • Lots of the English parts and approaches to sections were taken from the existing approved documentation in order to be consistent and conform to known preferred/approved language/approach
    • Opened dozens of issues for docs team on issues found in other docs while writing these docs
    • Ideally any issues on docs/approaches that apply to more than just this PR should be solved generally instead of just here
  • This mostly does not take a position on the reordering approach taken by the scaffolding (dozens of comments left on MVP .NET referential feature & inter-tech how-to documentation #2769, but that is unrelated to this work). For the most part, it just filled in blanks, but minor things were added/removed.

@cretz cretz requested a review from a team as a code owner May 3, 2024 17:22

### Custom Type Data Conversion

<!-- CONTENT-->
<!-- TODO(cretz): Develop https://github.com/temporalio/samples-dotnet/issues/38 first -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this section pending that sample, or if it's urgent I can prioritize it

@flossypurse flossypurse merged commit 9d1d846 into dotnet May 6, 2024
1 of 2 checks passed
@flossypurse flossypurse deleted the dotnet-initial branch May 6, 2024 17:48
flossypurse added a commit that referenced this pull request May 28, 2024
* scaffolding .net pages

* adding additional pages to guide

* add keywords

* updating with new pages

* updating ordering and removing

* removing Go references

* .NET docs (#2799)

Co-authored-by: Cully Wakelin <cully@temporal.io>

* edits & config

* edits

* align titles

* link

* adds how to format

* adding toc 1

* changing to lowercase / unbold

* index page - bones and links

* spacing

* adding to index

* adding to index intro sentence

* iframe

* adding more content

* casing

* updates and adding

* changing to temporal service & misc

* small change to list

* adding content to continue-as-new

* small thing

---------

Co-authored-by: Jwahir Sundai <jwahir.sundai@temporal.io>
Co-authored-by: Chad Retz <chad@temporal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants