Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow specifying TLS configuration #294

Closed
sd-hypredge opened this issue May 9, 2022 · 6 comments
Closed

[Feature Request] Allow specifying TLS configuration #294

sd-hypredge opened this issue May 9, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@sd-hypredge
Copy link

Is your feature request related to a problem? Please describe.

The ability to specify and configure TLS options is documented (https://docs.temporal.io/docs/server/configuration/#tls) but not implemented in the charts

Describe the solution you'd like

Ability to configure and MTLS options in values.yaml

Additional context

@sd-hypredge sd-hypredge added the enhancement New feature or request label May 9, 2022
@sd-hypredge
Copy link
Author

The capability is just an incremental change over existing chart, hence I have not submitted a formal proposal.
I have an implementation that follows the outline of the mechanics described in the documentation (https://docs.temporal.io/docs/server/configuration/#tls) , and serves the use case . I will contribute a PR if the feature request is prioritized for implementation

@lerminou
Copy link
Contributor

lerminou commented Jun 21, 2022

Hi, I made a PR a long time ago but closed because they wanted to revamp the project ...
#162

(I'm still using it for myself and our organization because TLS is a prerequisite)

@gthomson31
Copy link

@lerminou Coming accross the exact same issue at the moment and need to setup mTLS for the frontend SDK as a prerequisite - Will take a look at your PR 👍

@p4p4
Copy link

p4p4 commented Jul 12, 2022

@underrun does it make sense to wait for the new helm charts, is it likely that this feature will be added to the existing helm charts, or should we in the meantime customize the existing chart ourselves locally (similar to PR #162), if we need the feature?
Thanks for any feedback :)

@joshbranham
Copy link
Contributor

What is the chances the original proposed PR can be re-opened? This proposal is now closed, which leads me to believe nobody internal is working on it. temporalio/proposals#42

@robholland
Copy link
Contributor

I believe all aspects of this are now supported by the current chart. Please re-open if this is not the case and I will work with you to get whatever is missing sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants