Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to provide DB credentials from a file #321

Closed
joebowbeer opened this issue Sep 20, 2022 · 1 comment
Closed

[Feature Request] Ability to provide DB credentials from a file #321

joebowbeer opened this issue Sep 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joebowbeer
Copy link

Is your feature request related to a problem? Please describe.

How to provide DB credentials to Temporal from a file?

The existingSecret method of providing a database password injects the password as an environment variable using valueFrom / secretKeyRef.

However, CIS Benchmark generally recommends not passing secrets as env vars:

Prefer using secrets as files over secrets as environment variables

Describe the solution you'd like

Can providing a secret as a file be supported as an option?

Additional context

Kubernetes Secret Store CSI Driver will mount secrets from external sources as volumes without even creating a secret. This is judged to be even more secure; the fewer Secrets in Kubernetes the better.

In either case, Temporal would be consuming the password from a file instead of from env vars.

@joebowbeer joebowbeer added the enhancement New feature or request label Sep 20, 2022
@robholland
Copy link
Contributor

Temporal itself does not support this so neither will the helm chart. Please open an issue on http://github.com/temporalio/temporal and re-open here if the feature is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants