feat: add custom secret label and annotation options to chart #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underrun
approved these changes
Apr 26, 2023
omerosaienni
pushed a commit
to vhadianto/temporal-helm-charts
that referenced
this pull request
Jan 19, 2024
…alio#287) Co-authored-by: Mind.R <3825716+mindaugasrukas@users.noreply.github.com>
omerosaienni
pushed a commit
to vhadianto/temporal-helm-charts
that referenced
this pull request
Jan 19, 2024
…alio#287) Co-authored-by: Mind.R <3825716+mindaugasrukas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small change and motivation is same as #280, so directly create a PR.
What was changed
This PR adds the ability to set custom labels and annotations to the secret resources. It only supports cluster level configuration knob, so users cannot add component level extra labels and annotations to the secret resources.
Why?
In our case, we inject sensitive data (e.g. database password) from remote secret store (e.g. GCP Secret Manager) using mutating admission webhook, and adding labels to tell our custom admission webhook to inject sensitive data or not. Other common use-case might be adding annotations to the secret resources and mutate them by Vault Agent Injector. I'm not sure there are some use-cases to require component level labels and annotations, so just add cluster level options.
Checklist
How was this tested:
I ran this PR through
helm template temporal -n temporal -f values.yaml .and confirmed no change to the output from previous, then added some label and annotation key:value pairs and confirmed the appeared in the correct places in the YAML.Any docs updates needed?
No. The existing custom pod level labels and annotations functionality is also undocumented.