Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable whitespace removal for include temporal.serviceAccount #381

Merged

Conversation

2hamed
Copy link
Contributor

@2hamed 2hamed commented May 10, 2023

Fixes issue: #380

What was changed

Removed the hyphen (-) at the beginning of the include function. It was causing all whitespaces to be removed from the output resulting in serviceAccount: ... to be on the same line as the previous statement.

@2hamed 2hamed requested review from a team as code owners May 10, 2023 06:38
@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@crhuber
Copy link

crhuber commented May 17, 2023

@rodrigozhou afaict the lastest release is broken until this is merged

@mindaugasrukas mindaugasrukas self-assigned this May 23, 2023
Copy link
Contributor

@mindaugasrukas mindaugasrukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindaugasrukas mindaugasrukas merged commit 5d06c63 into temporalio:master May 27, 2023
1 check passed
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request Jan 19, 2024
omerosaienni pushed a commit to vhadianto/temporal-helm-charts that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants