Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use visibility server when defining visibility config #436

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

bakjos
Copy link
Contributor

@bakjos bakjos commented Oct 24, 2023

What was changed

Why?

When the default store uses cassandra and the visibility store sql the config was not including the sql part

Checklist

  1. Closes

  2. How was this tested:

Using the following values

server:
  replicaCount: 1
  config:
    persistence:
      default:
        cassandra:
          hosts:
            - cassandra
          port: 9042
      visibility:
        driver: "sql"
        sql:
          driver: "postgres"
          host: "postgres"
          port: 5432
          database: "temporal_visibility"
          user: "postgres"
          password: "postgres"
          maxConns: 20
          maxConnLifetime: "1h"
  1. Any docs updates needed?

@bakjos bakjos requested review from a team as code owners October 24, 2023 23:26
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@robholland robholland merged commit dfecb23 into temporalio:master Jun 8, 2024
2 checks passed
@robholland
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants