Fix: Quote ES credentials #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Elasticsearch plaintext credentials are now escaped to respect password which contains special characters
Why?
Without this change it's impossible to use password with specials characters which might be obligatory for some 3rd party managed Elasticsearch solutions.
E.g. - When using AWS Opensearch you're obliged to use special symbols if using master password istead of IAM auth.
Checklist
Closes [Bug] Can't use specials character in password with the Elasticsearch visibility storage #504
How was this tested:
We're using custom fork with this change already.
Any docs updates needed?
No