Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Does not work for workflow with multiple args #59

Open
Irvenae opened this issue Feb 1, 2023 · 1 comment
Open

[Bug] Does not work for workflow with multiple args #59

Irvenae opened this issue Feb 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Irvenae
Copy link

Irvenae commented Feb 1, 2023

What are you really trying to do?

Trying to run a TS workflow driven by the test bench. The TS workflow has multiple arguments.

Describe the bug

I looked into the code and it uses interface{} while in the executeWorkflow function it assumes ...interface{}
When you make a config with args: [{"test":123}, {"test":123}] the workflow will be ran with 1 argument containing this array instead of the array. The args should be unpacked when input is an array.

I am not a Go developer so I don't know how to modify this best.

(Probably I will just port this code to TS anyway for easier construction / extension of the bench tests)

@Irvenae Irvenae added the bug Something isn't working label Feb 1, 2023
@Irvenae
Copy link
Author

Irvenae commented Feb 1, 2023

A potential easy solution is to expect []interface{} for args. (I will try this out)
EDIT: This seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant