Move codec-server and grpc-proxy to own module #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #237 |
Quinn-With-Two-Ns
force-pushed
the
seprate-modules
branch
from
a8c3be1
to
b0344d5
Compare
Merged
cretz
reviewed
Jan 22, 2024
| github.com/google/uuid v1.5.0 | ||
| go.temporal.io/api v1.26.0 | ||
| go.temporal.io/sdk v1.25.1 | ||
| go.temporal.io/server v1.22.4 |
There was a problem hiding this comment.
I don't think the codec server sample should have to depend on the server library at all (other SDKs get along fine without it, though they don't have OIDC, but surely we can copy stuff). But I understand if now is not the time you want to remove this dependency.
There was a problem hiding this comment.
Yes I would rather do any changes like that in a separate PR
Quinn-With-Two-Ns
force-pushed
the
seprate-modules
branch
2 times, most recently
from
f5cae38
to
867dd8f
Compare
cretz
approved these changes
Jan 22, 2024
Quinn-With-Two-Ns
force-pushed
the
seprate-modules
branch
from
867dd8f
to
a5a02ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move codec-server and grpc-proxy to own module. This will let us decouple most of our samples dependencies from the sever dependencies.