OpenTelemetry sample #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
opentelemetry
branch
from
1ad7c8f
to
adcdd86
Compare
# Conflicts: # README.md # poetry.lock
| metrics: | ||
| receivers: [otlp] | ||
| exporters: [logging] | ||
| processors: [batch] |
There was a problem hiding this comment.
Not following exactly, but definitely no need for a newline at the end of the YAML file (also no harm either of course)
There was a problem hiding this comment.
yeah not need, just some things complain like github complain if there is no newline at the end of a file
There was a problem hiding this comment.
I think it's more of a "notice" than a complaint (same with git diff in general since humans can't otherwise tell)
| To run, first see [README.md](../README.md) for prerequisites. Then run the following to start a Jaeger container to | ||
| view the trace results: | ||
|
|
||
| docker run -d --name jaeger \ |
There was a problem hiding this comment.
does a user need to install this container separately?
There was a problem hiding this comment.
No, the container is automatically downloaded if not present by docker
Quinn-With-Two-Ns
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add OpenTelemetry sample
Checklist