Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Core throws HeartbeatTimeoutNotSet when activity heartbeats and no heartbeat timeout is configured #109

Closed
bergundy opened this issue Apr 26, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@bergundy
Copy link
Member

Describe the bug
As described in title, record_activity_heartbeat throws when there's no heartbeat timeout configured.

.ok_or(ActivityHeartbeatError::HeartbeatTimeoutNotSet)?

It would be better to ignore or simply warn in this case since the activity sending heartbeats is decoupled from the workflow that sets its ActivityOptions.

To Reproduce
Schedule an activity without a heartbeat timeout.

@bergundy bergundy added the bug Something isn't working label Apr 26, 2021
@Sushisource
Copy link
Member

For posterity: @bergundy As we discussed it makes sense to solve this by re-routing the error on the lang side. Let me know if we need to do anything else here otherwise you can close/move this.

@bergundy
Copy link
Member Author

Agreed, I'll come up with a design for propagating these errors back into the activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants