Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid timing-sensistive sleeps in test code #162

Open
Sushisource opened this issue Aug 7, 2021 · 0 comments
Open

Avoid timing-sensistive sleeps in test code #162

Sushisource opened this issue Aug 7, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Sushisource
Copy link
Member

We have a handful of tests that require sleeps to get things to happen in an expected order. This is obviously not ideal. We need a reasonable way to wait for certain things to happen deep in the internals of the code and expose that to tests in a way that doesn't require making all sorts of ugly changes purely for that ability.

If we could leverage tracing for this, that'd be nice. We could just wait to see some specific event in the test.

@Sushisource Sushisource added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant