Drain buffered polls on shutdown #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Aug 5, 2021
src/core_tests/workflow_tasks.rs
Outdated
| let poll_fut = async move { | ||
| // Now poll again, which will start spinning, and buffer the next WFT with timer fired in it | ||
| // - it won't stop spinning until the first task is complete | ||
| let t = dbg!(core.poll_workflow_task(TEST_Q).await.unwrap()); |
There was a problem hiding this comment.
Note that this is only required today because core doesn't poll without an outstanding poll request from lang.
| }; | ||
| tokio::join!(poll_fut, complete_first, async { | ||
| // If the shutdown is sent too too fast, we might not have got a chance to even buffer work | ||
| tokio::time::sleep(Duration::from_millis(5)).await; |
There was a problem hiding this comment.
You know my opinion on time sensitive tests like this.
We should have a better way of timing the shutdown.
# Conflicts: # src/workflow/workflow_tasks/concurrency_manager.rs
Sushisource
force-pushed
the
drain-buffered-polls-on-shutdown
branch
from
9d15485
to
1aa18f8
Compare
* Fixes resultant hang in test * A whole bunch of refactoring to expose worker options in test code to test that
Sushisource
force-pushed
the
drain-buffered-polls-on-shutdown
branch
from
bb1ad3a
to
2c83e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Buffered polls are now drained before poll returns shutdown
Why?
Avoid pointlessly timing out workflow tasks the worker has claimed while shutting down
Checklist
Closes Drain buffered server responses on shutdown #160
How was this tested:
New test
Any docs updates needed?