Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Split into more crates to allow shared workflows between integ/replay tests #220

Closed
Sushisource opened this issue Nov 12, 2021 · 1 comment · Fixed by #252
Assignees
Labels
enhancement New feature or request

Comments

@Sushisource
Copy link
Member

Right now there's no good way to define shared workflows in the test_utils crate because it depends on core in non-dev mode, but core depends on it in dev-mode, and thus if you try to use shared workflows in unit tests types mismatch and everything breaks.

Seemingly the only real way to fix this is to split out all the code that deals with mocking server responses and building fake histories into yet another crate (as well as possibly another crate for all the gateway stuff, possibly the pollers abstraction) so that we can define tests which can use mock responses and the history builder etc and also depend on the shared workflows.

Pretty big and annoying chunk of work but ultimately will result in a nicer structure

@Sushisource Sushisource added the enhancement New feature or request label Nov 12, 2021
@Sushisource Sushisource changed the title [Feature Request] Split into more crates to allow shared workflows [Feature Request] Split into more crates to allow shared workflows between integ/replay tests Nov 12, 2021
@Sushisource
Copy link
Member Author

Almost certainly makes sense to just do #176 at the same time too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant