Factor out test worker #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
requested review from
bergundy,
cretz and
Spikhalskiy
as code owners
cretz
approved these changes
Mar 14, 2022
cretz
reviewed
Mar 14, 2022
| @@ -2,6 +2,13 @@ | |||
| name = "temporal-client" | |||
| version = "0.1.0" | |||
| edition = "2021" | |||
| authors = ["Spencer Judge <spencer@temporal.io>"] | |||
There was a problem hiding this comment.
Doesn't really matter, but we've been setting this to Temporal Technologies Inc <sdk@temporal.io> in Python to not attach specific names.
Sushisource
force-pushed
the
factor-out-test-worker
branch
from
df347ac
to
930646d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Factor out test-only concerns of the SDK worker into the test utils package.
Add more license files / other stuff to crates that needed it
Why?
One step on the road to #222
Checklist
Closes
How was this tested: