Fix panic on evict w/ buffered tasks #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
reviewed
Dec 14, 2023
| @@ -386,7 +386,7 @@ impl WFStream { | |||
| // We accept that there might be query tasks remaining in the buffer if we evicted | |||
| // and re-instantiated here. It's likely those tasks are now invalidated anyway. | |||
| if maybe_buffered.has_tasks() && should_evict { | |||
| panic!("There were leftover buffered tasks"); | |||
| warn!("There were leftover buffered tasks when evicting run"); | |||
There was a problem hiding this comment.
Can you confirm -- you don't need to drain the buffer contents? So these are either going to be treated as valid items, or the buffer is about to be drained anyway, or destroyed?
There was a problem hiding this comment.
The tasks will just get dropped. It's not a meaningful issue for the reason the comment mentions. Worst case the task was valid, and it'll time out and get retried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This never should have been a panic in the first place. I think I had it that way while testing and forgot to undo it. It's fairly hard to trigger.