Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate pending activations by returning new activations from complete #96

Closed

Conversation

Sushisource
Copy link
Member

What was changed:

Return new activations from completing them, when required

Why?

  • Eliminates complexity around pending activations
  • When you call poll, you always poll the server now
  • When you poll, your activation is always for that task queue
  • Eliminates question about how to "buffer" server responses if lang is dealing with pending activations - so closes What happens when a new pending activation interrupts long poll? #91

Checklist

TODO:

  • Saw stalling behavior if lang side didn't deal with returned activations from a completion (I think this is because workflow task timeout isn't working right)
  • Cleanup pass
  1. Closes issue:
    Closes What happens when a new pending activation interrupts long poll? #91

  2. How was this tested:
    Existing & new tests

@Sushisource
Copy link
Member Author

This may get closed in favor of another solution Max helped us realize that maintains the existing API by simply not starting any polling behavior until all pending activations are cleared out. Will leave as draft until I've had time to explore that.

@vitarb
Copy link
Contributor

vitarb commented Apr 19, 2021

As far as I understand, we are not going to land this one, right?

@Sushisource
Copy link
Member Author

As far as I understand, we are not going to land this one, right?

Nope. Not for alpha at least. Want to keep it around if we revisit after.

@bergundy
Copy link
Member

@Sushisource should we keep this draft?
I think we pretty much realized that this not the direction we're taking.

@Sushisource
Copy link
Member Author

👋 Goodbye, PR. I still think you're a nifty idea but it's been too long.

@Sushisource Sushisource closed this Dec 3, 2021
@Sushisource Sushisource deleted the completes-return-activations branch December 3, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What happens when a new pending activation interrupts long poll?
3 participants