Demonstrate OpenTelemetry + dependency injection #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cretz
reviewed
Nov 13, 2023
glencbz
force-pushed
the
otel-di-example
branch
2 times, most recently
from
966bdac
to
1c65778
Compare
glencbz
changed the title
glencbz
force-pushed
the
otel-di-example
branch
2 times, most recently
from
b0acfb3
to
1b09094
Compare
|
Updated and removed some cruft from the project I copy-pasted from. |
cretz
reviewed
Nov 15, 2023
glencbz
force-pushed
the
otel-di-example
branch
from
1b09094
to
154cb13
Compare
src/Temporalio.Extensions.OpenTelemetry/README.md doesn't contain an example of how to configure OpenTelemetry when using dependency injection. It's pretty easy to figure out how to configure the client by also reading the src/Temporalio.Extensions.Hosting/README.md, _but_ if one uses a hosted worker, it typically has to be configured separately. This is a common pitfall (according to https://temporalio.slack.com/archives/C012SHMPDDZ/p1699016782885319?thread_ts=1698974629.231319&cid=C012SHMPDDZ at least). Add an example to src/Temporalio.Extensions.OpenTelemetry/README.md to reduce the guesswork from users.
glencbz
force-pushed
the
otel-di-example
branch
from
154cb13
to
0afbe79
Compare
cretz
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Temporal folks! Here's a doc change for something I figured out that I wish was called out in the docs. Feel free to reword this as you wish.
What was changed
Add an example of configuring OpenTelemetry with dependency injection to src/Temporalio.Extensions.OpenTelemetry/README.md.
Why?
src/Temporalio.Extensions.OpenTelemetry/README.md doesn't contain an example of how to configure OpenTelemetry when using dependency injection. It's pretty easy to figure out how to configure the client by also reading the src/Temporalio.Extensions.Hosting/README.md, but if one uses a hosted worker, it typically has to be configured separately. This is a common pitfall (according to
https://temporalio.slack.com/archives/C012SHMPDDZ/p1699016782885319?thread_ts=1698974629.231319&cid=C012SHMPDDZ at least), so document this.
Checklist
NA
NA
NA