Alternative CreateTemporalActivityDefinition

[houseofcat]

What Changed

Allow the usage of AsyncServiceProvider in the ServiceProviderExtensions for NET6+ during CreateTemporalActivityDefinitions.

• Backwards compatible.
• Choose the package to run as NET6.0. Preprocess directives are only looking for NET6_0_OR_GREATER making it very easy to change to NET6+.

Compiler recommend converting delegate variable...

Func<object?[], Task<object?>> invoker = async args =>

...to a local and async function.

async Task<object?> Invoker(object?[] args)

and I fully agree. After feedback, this went through the rounds as being compatible.

Why?

Uses an AsyncServiceScope which allows the IAsyncDisposable interface to be invoked when created by CreateAsyncScope from the IServiceProvider.

This is a more modern way to handle IAsyncDisposable classes that are used in Dependency Injection. Without it, you can trigger these types of exceptions.

Unhandled exception. System.InvalidOperationException: 'MyClass' type only implements IAsyncDisposable. Use DisposeAsync to dispose the container.

Also handles IDisposable the same as it did before.

Checklist

1. Closes

Should close issue #204

2. Testing

Ran all UnitTests locally to ensure backwards compatibility. Future testing needed when the main Temporalio is brought up to be compatible with NET6 or NET8.

224/224 Passing.

3. Any docs updates needed?

I do not believe so. This code follows typical usage as presented by Microsoft internally to AspNetCore/BackgroundServices or through the dotnet/runtime.

[cretz]

Looks good! Just a couple of other parts I was concerned about, but I like the approach in general (sorry for the run-around, thanks for sticking with it)

[cretz]

Thanks again!